Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(middleware-user-agent): detect cbor, retry, account id features #6552

Merged
merged 4 commits into from
Oct 10, 2024
Merged

chore(middleware-user-agent): detect cbor, retry, account id features #6552

merged 4 commits into from
Oct 10, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 8, 2024 •
edited
Loading

  • for feature detection, use the selected authScheme identity instead of calling the credentials provider

  • detect endpoint resolved with account id

  • detect rpc v2 cbor

  • detect retry strategy

  • move user agent middleware to finalizeRequest step canceled due to complications with signing

  • e2e

  • e2e:legacy

@kuhe kuhe requested a review from a team as a code owner October 8, 2024 18:43
@kuhe kuhe force-pushed the chore/features3 branch 7 times, most recently from 81187b9 to 5b00e14 Compare October 8, 2024 21:34
@kuhe kuhe changed the title chore(middleware-user-agent): use authScheme identity instead of credentials provider fix(middleware-user-agent): use authScheme identity instead of credentials provider Oct 9, 2024
@kuhe kuhe force-pushed the chore/features3 branch from 25e096a to 9e98833 Compare October 9, 2024 15:58
@kuhe kuhe changed the title fix(middleware-user-agent): use authScheme identity instead of credentials provider chore(middleware-user-agent): detect cbor, retry, account id features Oct 9, 2024
@kuhe kuhe force-pushed the chore/features3 branch from 9e98833 to 11f4366 Compare October 9, 2024 17:43
@kuhe kuhe force-pushed the chore/features3 branch 2 times, most recently from 2cf858e to efffd88 Compare October 9, 2024 20:13
@kuhe kuhe force-pushed the chore/features3 branch from efffd88 to 500bcbb Compare October 9, 2024 20:30
@kuhe kuhe merged commit 534e028 into aws:main Oct 10, 2024
3 checks passed
@kuhe kuhe deleted the chore/features3 branch October 10, 2024 14:06
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siddsriv siddsriv siddsriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @siddsriv